Added support for salting #1040
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also added more hashing algorithms which can be used - Salt is retrieved by the saltQuery parameter in context.xml which should include a DQL query
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
This was referenced Oct 19, 2016
|
Nice, but this might be a good opportunity to drop MD5 support alltogether :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for hash salting and support for more hashing algorithms.
There's a new parameter called saltQuery which is defined in context.xml and expects
a DQL Query string to get the salt from a specified table.
The hashAlgorithm in context.xml is now being respected and can be given the following values:
if none of the above is given the password hashing mechanism just returns the password with no hashing.